Hello,

 

while reading the build tools scripts I found this part of the license text to be fishy:

# This file is licensed under the terms of the GNU General Public
# License version 2. This program is licensed "as is" without any
# warranty of any kind, whether express or implied.

I think the intent was to say "whether expressed or implied".

 

Can I get confirmation, so I can prepare a PR for changing all the (cut'n'pasted) occurrences ?

Well, I rather think it should be : The program is provided "as is" without any warranty of any kind, whether express or implied.

So you'd rather keep the "express warranty" (I can't understand what that would mean, care to explain it to me ?) and change "This" into "The" ?

Thanks, I'm not a native english speaker so I may be completely wrong about this, which is why I asked...

If we find better words, just go, I have no objections & if you are already started to make changes to this part, than add this (planned) change:

# Copyright (c) 2015 Igor Pecovnik, igor.pecovnik@gma**.com

# Copyright (c) Authors: http://www.armbian.com/authors

Will do, if we get consensus from native english speakers

Will do, if we get consensus from native english speakers

We don't have to, there are standard boilerplate texts to copy-paste from, i.e. here: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html in section "How to Apply These Terms to Your New Programs"

Yep, I searched a bit before asking, and looking at the fsf/gnu license help, but as I didn't find the same text I assumed armbian having chosen this specific wording on purpose...

 

Changing a word to be "better english" (if I'm not mistaken about that express warranty" wording) is not really the same as changing license text (removing a part that can be legally important) and would need approval by all copyright holders of each file.

 

The former I'd do, the latter I'll pass... ;-)