Skip to content
View in the app

A better way to browse. Learn more.

Armbian Community Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

[Armbian build PR] - Split `/lib/*.sh` into functions structure which similar like `armbian-next`

Featured Replies

Description

I notice that the first commit of armbian-next contains too many things (armbian-next: huge refactor, shellfmt, codesplit, logging/error handling). It's really hard to find out what changes we do, because we both split /lib/*.sh and change the code in one commit. It will loss the association between master and armbian-next.

This PR is just split /lib/*.sh without changing any codes (except the first commit and the remove of source in /lib/main.sh). So users can find out where the codes come and then following the original commit log.

If we want to merge armbian-next, this PR can make us more easily to find out the differentiation and review.

If we don't merge armbian-next, this PR can let us have a more clearing structure.

And it change nothing, so it still work well.

IMO, we should split armbian-next into several PR. Every PR for just a feature. It will be more easy to review and we can have a clearing commit log. I can help for this. Let me known how you think about this.

Note: Please just Create a merge commit instand of Squash and merge. So the commit logs can be kept.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • [X] Build

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] Any dependent changes have been merged and published in downstream modules

View the full article

Guest
This topic is now closed to further replies.

Account

Navigation

Search

Search

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.